Re: [PATCH 2/4] media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable

[Konrad Dybcio]

On 10/25/23 00:42, Bryan O'Donoghue wrote:
> For the various versions of VFE we have a boiler-plate
> pm_domain_on/pm_domain_off callback pair of the general form.
>
> - Error check.
>    Not always done but applicable to all.
>
> - device_link_add (DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME |
>                     DL_FLAG_RPM_ACTIVE);
>
> - Error check returning -EINVAL on error.
>
> - Return 0
>
> Reduce the pattern down to a common callback. VFE 4.1 is a special case
> which to me also indicates that it is worthwhile maintaining an indirection
> for the vfe_pm_domain_{on|off} for now.
Are there issues when powering it off like all the others?

> Otherwise lets chuck out a bunch of needlessly replicated code.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad