Re: [PATCH v3 3/3] nvme-auth: always set valid seq_num in dhchap reply

[Hannes Reinecke]

On 10/25/23 12:51, Mark O'Donovan wrote:
> Currently a seqnum of zero is sent during uni-directional
> authentication. The zero value is reserved for the secure channel
> feature which is not yet implemented.
>
> Relevant extract from the spec:
> The value 0h is used to indicate that bidirectional authentication
> is not performed, but a challenge value C2 is carried in order to
> generate a pre-shared key (PSK) for subsequent establishment of a
> secure channel
>
> Signed-off-by: Mark O'Donovan <shiftee@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> ---
> v1: used incorrect prefix nvme-tcp
> v2: added spec extract to commit message
> v3: read the seq-num in nvme-target code
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes