Re: [PATCH RFC 7/8] arm64: dts: qcom: sm8650-mtp: add interconnect dependent device nodes

[Neil Armstrong]

On 25/10/2023 11:11, Konrad Dybcio wrote:
> On 10/25/23 09:47, Neil Armstrong wrote:
> > Now interconnect dependent devices are added in sm8650 DTSI,
> > now enable more devices for the Qualcomm SM8650 MTP board:
> > - PCIe
> > - Display
> > - DSPs
> > - SDCard
> > - UFS
> > - USB role switch with PMIC Glink
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> [...]
>
> > +&ufs_mem_hc {
> > +    reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
> > +
> > +    vcc-supply = <&vreg_l17b_2p5>;
> > +    vcc-max-microamp = <1300000>;
> > +    vccq-supply = <&vreg_l1c_1p2>;
> > +    vccq-max-microamp = <1200000>;
> You should amend these regulators' nodes with loadsetting
> and allowed mode properties

Ack will do that on both patches 7 & 8,

Thanks,
Neil

> Konrad