Re: [PATCH] NFS: Fix an off by one in root_nfs_cat()

From: Benjamin Coddington
Date: Wed Oct 25 2023 - 08:35:26 EST


On 24 Oct 2023, at 17:47, Christophe JAILLET wrote:

> The intent is to check if the 'dest' is truncated or not. So, >+ should be
> used instead of >, because strlcat() returns the length of 'dest' and 'src'
> excluding the trailing NULL.
>
> Fixes: 56463e50d1fc ("NFS: Use super.c for NFSROOT mount option parsing")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Minor typo in the body: >+ should be >=, otherwise looks right.

Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx>

Ben