Re: [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative

[Juergen Gross]

On 25.10.23 15:44, Borislav Petkov wrote:
> On Wed, Oct 25, 2023 at 03:31:07PM +0200, Juergen Gross wrote:
> > There is
> >
> > #define nop() asm volatile ("nop")
> >
> > in arch/x86/include/asm/special_insns.h already.
>
> Then call it "nop_func" or so.

Okay.

> > It might not be needed now, but are you sure we won't need it in future?
>
> No, I'm not.
>
> What I'm sure of is: stuff should be added to the kernel only when
> really needed. Not in the expectation that it might potentially be
> needed at some point.

Will double check whether it is needed now.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature