Re: [PATCH] hwmon: HS3001: remove redundant store on division

From: Guenter Roeck
Date: Wed Oct 25 2023 - 15:00:25 EST


On Mon, Oct 23, 2023 at 02:58:28PM +0100, Colin Ian King wrote:
> Currently the local variable hum is being divided by a constant and
> the results is being re-assigned back to hum before the value is being
> returned to the caller. The assignment to hum is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> drivers/hwmon/hs3001.c:65:9: warning: Although the value stored to 'hum'
> is used in the enclosing expression, the value is never actually read
> from 'hum' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Applied.

Guenter