Re: [PATCH v7 2/4] riscv: Checksum header

From: Charlie Jenkins
Date: Wed Oct 25 2023 - 17:20:31 EST


On Wed, Oct 25, 2023 at 11:18:40PM +0200, Arnd Bergmann wrote:
> On Wed, Oct 25, 2023, at 23:11, Charlie Jenkins wrote:
> >
> > Thank you for pointing that out, I had not realized that macro existed.
> > Since riscv keeps NET_IP_ALIGN at 0 it should be expected that
> > ip_fast_csum is only called with 32-bit aligned addresses. I will update
> > the comment and refer to that macro. riscv supports misaligned accesses
> > but there are no guarantees of speed.
>
> Just to clarify for your comment: riscv gets the default value of '2',
> which is the one that makes the header aligned.
>
> Arnd

Oops, typo. I meant to write 2.

- Charlie