Re: [PATCH 3/3] checkpatch: add ethtool_sprintf rules

From: Joe Perches
Date: Wed Oct 25 2023 - 19:53:18 EST


On Wed, 2023-10-25 at 23:40 +0000, Justin Stitt wrote:
> Add some warnings for using ethtool_sprintf() where a simple
> ethtool_puts() would suffice.
>
> The two cases are:
>
> 1) Use ethtool_sprintf() with just two arguments:
> > ethtool_sprintf(&data, driver[i].name);

OK.

> or
> 2) Use ethtool_sprintf() with a standalone "%s" fmt string:
> > ethtool_sprintf(&data, "%s", driver[i].name);

I'm rather doubt this is really desired or appropriate.