Re: renesas_sdhi problems in 5.10-stable was Re: [PATCH 5.10 000/226] 5.10.198-rc1 review

[Guenter Roeck]

On 10/25/23 15:00, Pavel Machek wrote:
> Hi!
>
> > > > > I don't have a HopeRun HiHope RZ/G2M, but both v5.10.198 and v5.10.199
> > > > > seem to work fine on Salvator-XS with R-Car H3 ES2.0 and Salvator-X
> > > > > with R-Car M3-W ES1.0, using a config based on latest renesas_defconfig.
> > > >
> > > > Sorry, I looked at the wrong log on R-Car M3-W.
> > > > I do see the issue with v5.10.198, but not with v5.10.199.
> > >
> > > It seems to be an intermittent issue. Investigating...
> >
> > After spending too much time on bisecting, the bad guy turns out to
> > be commit 6d3745bbc3341d3b ("mmc: renesas_sdhi: register irqs before
> > registering controller") in v5.10.198.
>
> Thanks for bisection, let me take a look.
>
> I reverted 6d3745bbc3341d3b on top of 5.10.199 and that solved my
> issues:
>
> https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/1049624365
>
> (Strange thing is I seen a failure on qemu this fixed, too. I guess
> that must be some kind of glitch).

qemu interrupt timing is different, which can result in exposing race
conditions which are not seen with real hardware. Plus, of course, there
is always the possibility that the qemu emulation is buggy.

What is your qemu command line ? I'd like to add it to my tests if possible.

Thanks,
Guenter