Re: [PATCH v3.1 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC

[Bjorn Andersson]

On Tue, Oct 24, 2023 at 10:40:04AM +0100, Bryan O'Donoghue wrote:
> On 24/10/2023 01:34, Stephen Boyd wrote:
> > Quoting Bryan O'Donoghue (2023-10-23 08:38:20)
> > > diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c
> > > new file mode 100644
> > > index 000000000000..0631bd5fad57
> > > --- /dev/null
> > > +++ b/drivers/clk/qcom/camcc-sc8280xp.c
> > > @@ -0,0 +1,3048 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > > + * Copyright (c) 2023, Linaro Ltd.
> > > + */
> > > +
> > > +#include <linux/clk-provider.h>
> > > +#include <linux/err.h>
> > 
> > Is this include used?
> > 
> > > +#include <linux/kernel.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of_device.h>
> > 
> > Should be mod_devicetable.h instead?
> > 
> > > +#include <linux/of.h>
> > 
> > Is this include used?
> > 
> > > +#include <linux/pm_clock.h>
> > > +#include <linux/pm_runtime.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/pm_runtime.h>
> > 
> > This got included twice.
> > 
> > > +
> > > +#include <dt-bindings/clock/qcom,sc8280xp-camcc.h>
> > > +
> > > +#include "clk-alpha-pll.h"
> 
> You're right, I didn't scrub the autogen headers.
> 
> Update sent as v3.2.
> 

Resubmitting one of the four patches as 3.2 confuses both me and the
tools. Please send a v4 of all 4 patches instead.

Regards,
Bjorn