Re: [PATCH v3] staging: rtl8192e: renamed variable TxCountToDataRate
From: kernel test robot
Date: Thu Oct 26 2023 - 01:09:09 EST
Hi Gary,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Gary-Rookard/staging-rtl8192e-renamed-variable-TxCountToDataRate/20231022-061649
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20231021215440.6584-1-garyrookard%40fastmail.org
patch subject: [PATCH v3] staging: rtl8192e: renamed variable TxCountToDataRate
config: i386-buildonly-randconfig-002-20231026 (https://download.01.org/0day-ci/archive/20231026/202310261254.JYIf89K5-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310261254.JYIf89K5-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310261254.JYIf89K5-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/staging/rtl8192e/rtl819x_HTProc.c:117:6: warning: no previous declaration for 'tx_count_to_data_rate' [-Wmissing-declarations]
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
^~~~~~~~~~~~~~~~~~~~~
vim +/tx_count_to_data_rate +117 drivers/staging/rtl8192e/rtl819x_HTProc.c
116
> 117 u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
118 {
119 u16 CCKOFDMRate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18,
120 0x24, 0x30, 0x48, 0x60, 0x6c};
121 u8 is40MHz = 0;
122 u8 isShortGI = 0;
123
124 if (nDataRate < 12)
125 return CCKOFDMRate[nDataRate];
126 if (nDataRate >= 0x10 && nDataRate <= 0x1f) {
127 is40MHz = 0;
128 isShortGI = 0;
129 } else if (nDataRate >= 0x20 && nDataRate <= 0x2f) {
130 is40MHz = 1;
131 isShortGI = 0;
132 } else if (nDataRate >= 0x30 && nDataRate <= 0x3f) {
133 is40MHz = 0;
134 isShortGI = 1;
135 } else if (nDataRate >= 0x40 && nDataRate <= 0x4f) {
136 is40MHz = 1;
137 isShortGI = 1;
138 }
139 return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
140 }
141
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki