RE: [PATCH 2/2] tty: n_gsm: add partial copyright Siemens Mobility GmbH

From: Starke, Daniel
Date: Thu Oct 26 2023 - 04:40:48 EST


> > + * Portions Copyright (c) 2022/23 Siemens Mobility GmbH
>
> I have no objection to you adding your copyright, you all have done a
> ton of great work here and it is correct to add. But the "Portions"
> line is odd, and isn't something we generally use. Can you just resend
> this with that word removed?
>
> > *
> > * * THIS IS A DEVELOPMENT SNAPSHOT IT IS NOT A FINAL RELEASE *
> > *
> > diff --git a/include/uapi/linux/gsmmux.h b/include/uapi/linux/gsmmux.h
> > index 4c878d84dbda..101ebd15954e 100644
> > --- a/include/uapi/linux/gsmmux.h
> > +++ b/include/uapi/linux/gsmmux.h
> > @@ -1,4 +1,5 @@
> > /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > +/* Portions Copyright (c) 2022/23 Siemens Mobility GmbH */
>
> Same here, just drop the "Portions"?

This was something suggested by our IP department. But sure, I will resend
this patch without the word included.

Best regards,
Daniel Starke