RE: [EXT] Re: [PATCH v6 02/11] dt-bindings: arm: fsl: add imx-se-fw binding doc

[Pankaj Gupta]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, October 4, 2023 12:06 PM
> To: Pankaj Gupta <pankaj.gupta@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>
> Cc: shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; clin@xxxxxxxx; conor+dt@xxxxxxxxxx;
> pierre.gondois@xxxxxxx; festevam@xxxxxxxxx; dl-linux-imx <linux-
> imx@xxxxxxx>; davem@xxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Gaurav Jain <gaurav.jain@xxxxxxx>;
> alexander.stein@xxxxxxxxxxxxxxx; Varun Sethi <V.Sethi@xxxxxxx>
> Subject: Re: [EXT] Re: [PATCH v6 02/11] dt-bindings: arm: fsl: add imx-se-fw
> binding doc
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 04/10/2023 06:10, Pankaj Gupta wrote:
> 
> >>
> >>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> >>> +
> >>> +required:
> >>> +  - compatible
> >>> +  - mboxes
> >>> +  - mbox-names
> >>> +  - fsl,mu-id
> >>
> >> How is memory-region optional?
> > Depending on the type of enclave IP and the FW, memory-region is
> configured optionally.
> > For i.MX8ULP and i.MX93, it is required. For i.MX8DXL, it is not required.
> 
> Then write it in the bindings in allOf:if:then:.
Accepted.

> 
> >>
> >>> +
> >>> +additionalProperties: false
> >>> +
> >>> +examples:
> >>> +  - |
> >>> +    ele_fw: se-fw {
> >>
> >> Drop unused labels.
> > I am sorry, if I am not able to understand your point here.
> > But, all the below labels are getting used.
> > I can remove the fsl,mu-id. Will do it in V7.
> 
> Comment was about labels, not properties.
The label "ele_fw", is needed to be placed in different DTSI file.

For instance, node is added in i.mx93.dtsi.
Using label, the memory-region property dependent on size of DDR on the platform, is placed in:

- imx93-11x11-evk.dts
 

> 
> Best regards,
> Krzysztof