Re: [PATCH 2/6] tty: serial: amba: Use BIT() macro for constant declarations

[Linus Walleij]

On Thu, Oct 26, 2023 at 12:41 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote:

> The driver uses bit shifts and hexadecimal expressions to declare
> constants. Replace that with the BIT() macro that clarifies intent.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> ---
>  include/linux/amba/serial.h | 182 ++++++++++++++++++++++----------------------

Since you don't know where this header may be included, you should
add #include <linux/bits.h> at the top of linux/amba/serial.h

With that fixed:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij