Re: [PATCH 6/6] tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options

From: Linus Walleij
Date: Thu Oct 26 2023 - 09:48:26 EST


On Thu, Oct 26, 2023 at 12:41 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote:

> pl011_console_get_options() gets called to retrieve currently configured
> options from the registers. Previously, LCRH_TX.WLEN was being parsed
> as either 7 or 8 (fallback). Hardware supports values from 5 to 8
> inclusive, which pl011_set_termios() exploits for example.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>

With Ilpo's comment fixed:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij