Re: [PATCH v3] firmware_loader: Abort new fw load request once firmware core knows about reboot

From: Mukesh Ojha
Date: Thu Oct 26 2023 - 10:34:45 EST




On 10/23/2023 9:45 PM, Luis Chamberlain wrote:
On Mon, Oct 23, 2023 at 06:11:18PM +0530, Mukesh Ojha wrote:
However, if you think we should rename this
'only_kill_custom' to something like its inverse 'kill_all' and reverse the
below check to be more meaningful now ?

if (kill_all || !fw_priv->need_uevent)

This seems like a better approach to make the intent clear and avoid
future confusion.

Thanks, have sent it here.

https://lore.kernel.org/lkml/1698330459-31776-1-git-send-email-quic_mojha@xxxxxxxxxxx/

-Mukesh


Luis