Re: [PATCH 0/3] ethtool: Add ethtool_puts()

From: Kees Cook
Date: Thu Oct 26 2023 - 11:47:25 EST


On Wed, Oct 25, 2023 at 11:40:31PM +0000, Justin Stitt wrote:
> @replace_2_args@
> identifier BUF;
> expression VAR;
> @@
>
> - ethtool_sprintf
> + ethtool_puts
> (&BUF, VAR)

I think cocci will do a better job at line folding if we adjust this
rule like I had to adjust the next rule: completely remove and re-add
the arguments:

- ethtool_sprintf(&BUF, VAR)
+ ethtool_puts(&BUF, VAR)

Then I think the handful of weird line wraps in the treewide patch will
go away.

--
Kees Cook