Re: [PATCH v2] hwmon: (pmbus/max31785) Add delay between bus accesses

From: Guenter Roeck
Date: Thu Oct 26 2023 - 12:49:47 EST


On 10/26/23 07:48, Lakshmi Yadlapati wrote:
Thank you Guenter!
Should I fix and send the patch again?


Please do. And don't top-post.

Thanks,
Guenter

On 10/25/23, 7:48 PM, "Guenter Roeck" <groeck7@xxxxxxxxx <mailto:groeck7@xxxxxxxxx> on behalf of linux@xxxxxxxxxxxx <mailto:linux@xxxxxxxxxxxx>> wrote:


On Mon, Oct 23, 2023 at 01:08:03PM -0500, Lakshmi Yadlapati wrote:
Changes since V1:
1. Changed the max31785_wait macro to a function, following the conventions
used in other drivers that had the same issue.
2. Changed the function names from max31785_i2c_smbus* to max31785_i2c_* and
from max31785_pmbus_* to _max31785_*, making them more concise.



Please check Documentation/process/submitting-patches.rst
for the expected patch format, specifically details on how
description and change log are supposed to look like.


Guenter