Re: [PATCH v4 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property

From: Chris Packham
Date: Thu Oct 26 2023 - 16:04:59 EST


(resend as plain text)


On 27/10/23 00:15, Wolfram Sang wrote:
>> + reset-gpios:
>> + description:
>> + GPIO pin providing a common reset for all downstream devices. This GPIO
>> + will be asserted then released before the downstream devices are probed.
> How about renaming this to "bus-reset-gpios"?
>
> Reason: When I read "reset-gpios", then I assume the device itself will
> be reset. In this case, the Marvell I2C controller. Some I2C mux devices
> and PCA9564 already use the property like I described.

I don't have an objection to "bus-reset-gpios" it would be trivial for
me to spin a v5 with the naming changed if everyone is in agreement
(given my timezone I might just send out a v5 with this change and then
it can be argued whether to apply v4 or v5).