Re: [PATCH 2/2] iommu/vt-d: Adopt new helper for looking up pci device

From: Huang, Jiaqing
Date: Fri Oct 27 2023 - 02:08:14 EST


On 10/24/2023 8:01 PM, Baolu Lu wrote:

> On 2023/10/24 16:41, Huang Jiaqing wrote:
>> Adopt the new iopf_queue_find_pdev func() to look up PCI device
>> for better efficiency and avoid the CPU stuck issue with parallel
>> heavy dsa_test.
>>
>> Signed-off-by: Huang Jiaqing <jiaqing.huang@xxxxxxxxx>
>> ---
>>   drivers/iommu/intel/svm.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
>> index 659de9c16024..0f1018b76557 100644
>> --- a/drivers/iommu/intel/svm.c
>> +++ b/drivers/iommu/intel/svm.c
>> @@ -672,7 +672,7 @@ static irqreturn_t prq_event_thread(int irq, void
>> *d)
>>           if (unlikely(req->lpig && !req->rd_req && !req->wr_req))
>>               goto prq_advance;
>>   -        pdev = pci_get_domain_bus_and_slot(iommu->segment,
>> +        pdev = iopf_queue_find_pdev(iommu->iopf_queue,
>>                              PCI_BUS_NUM(req->rid),
>>                              req->rid & 0xff);
>
> Minor: align the new line with the left parenthesis.

Got it, will fix it, thanks for catching!

BRs,
Jiaqing