[PATCH net-next 1/1] net: stmmac: add check for advertising linkmode request for set-eee

From: Gan Yi Fang
Date: Fri Oct 27 2023 - 02:54:31 EST


From: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@xxxxxxxxx>

Add check for advertising linkmode set request with what is currently
being supported by PHY before configuring the EEE. Unsupported setting
will be rejected and a message will be prompted. No checking is
required while setting the EEE to off.

Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@xxxxxxxxx>
Signed-off-by: Gan, Yi Fang <yi.fang.gan@xxxxxxxxx>
---
.../ethernet/stmicro/stmmac/stmmac_ethtool.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index f628411ae4ae..6c090d4b7117 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -867,8 +867,24 @@ static int stmmac_ethtool_op_set_eee(struct net_device *dev,
netdev_warn(priv->dev,
"Setting EEE tx-lpi is not supported\n");

- if (!edata->eee_enabled)
+ if (!edata->eee_enabled) {
stmmac_disable_eee_mode(priv);
+ } else {
+ __ETHTOOL_DECLARE_LINK_MODE_MASK(supported);
+ __ETHTOOL_DECLARE_LINK_MODE_MASK(advertised);
+
+ ethtool_convert_legacy_u32_to_link_mode(supported,
+ edata->supported);
+ ethtool_convert_legacy_u32_to_link_mode(advertised,
+ edata->advertised);
+
+ /*Check if the advertise speed is supported.*/
+ if (!bitmap_subset(advertised,
+ supported,
+ __ETHTOOL_LINK_MODE_MASK_NBITS)){
+ return -EOPNOTSUPP;
+ }
+ }

ret = phylink_ethtool_set_eee(priv->phylink, edata);
if (ret)
--
2.34.1