Re: [PATCH 2/4] clk: qcom: Add Global Clock controller (GCC) driver for SC8380XP

[Krzysztof Kozlowski]

On 25/10/2023 15:33, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> 
> Add support for the global clock controller found on SC8380XP
> based devices.
> 
> Co-developed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Signed-off-by: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> ---
>  drivers/clk/qcom/Kconfig        |   10 +
>  drivers/clk/qcom/Makefile       |    1 +
>  drivers/clk/qcom/gcc-sc8380xp.c | 6812 +++++++++++++++++++++++++++++++
>  3 files changed, 6823 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-sc8380xp.c
> 
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index ad1acd9b7426..013b3a1ad551 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -515,6 +515,16 @@ config SC_GCC_8280XP
>  	  Say Y if you want to use peripheral devices such as UART, SPI,
>  	  I2C, USB, UFS, SDCC, etc.
>  
> +config SC_GCC_8380XP
> +	tristate "SC8380XP Global Clock Controller"
> +	select QCOM_GDSC
> +	depends on COMMON_CLK_QCOM

Please stgart any new work starting from some driver in linux-next. You
would not make the same mistakes we fixed recently.

depends on ARM64 || COMPILE_TEST

Best regards,
Krzysztof