RE: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA

From: Zhang, Tina
Date: Fri Oct 27 2023 - 05:14:28 EST


Hi Joerg and Jason,

> -----Original Message-----
> From: Zhang, Tina
> Sent: Friday, October 27, 2023 3:37 PM
> To: Joerg Roedel <joro@xxxxxxxxxx>
> Cc: iommu@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse
> <dwmw2@xxxxxxxxxxxxx>; Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>; Will Deacon
> <will@xxxxxxxxxx>; Robin Murphy <robin.murphy@xxxxxxx>; Jason
> Gunthorpe <jgg@xxxxxxxx>; Tian, Kevin <kevin.tian@xxxxxxxxx>; Nicolin Chen
> <nicolinc@xxxxxxxxxx>; Michael Shavit <mshavit@xxxxxxxxxx>; Vasant
> Hegde <vasant.hegde@xxxxxxx>; Jason Gunthorpe <jgg@xxxxxxxxxx>
> Subject: RE: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
>
> Hi Joerg,
>
> > -----Original Message-----
> > From: Joerg Roedel <joro@xxxxxxxxxx>
> > Sent: Friday, October 27, 2023 3:12 PM
> > To: Zhang, Tina <tina.zhang@xxxxxxxxx>
> > Cc: iommu@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; David
> > Woodhouse <dwmw2@xxxxxxxxxxxxx>; Lu Baolu
> <baolu.lu@xxxxxxxxxxxxxxx>;
> > Will Deacon <will@xxxxxxxxxx>; Robin Murphy <robin.murphy@xxxxxxx>;
> > Jason Gunthorpe <jgg@xxxxxxxx>; Tian, Kevin <kevin.tian@xxxxxxxxx>;
> > Nicolin Chen <nicolinc@xxxxxxxxxx>; Michael Shavit
> > <mshavit@xxxxxxxxxx>; Vasant Hegde <vasant.hegde@xxxxxxx>; Jason
> > Gunthorpe <jgg@xxxxxxxxxx>
> > Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
> >
> > Hi Tina,
> >
> > On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote:
> > > From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> > >
> > > Linus suggested that the kconfig here is confusing:
> >
> > While this patch looks decent to me, you forgot to Cc Linus on it. In
> > general, given that it touches a couple of core files, I'd like to
> > wait for some more people to have a look at it and not rushing anything in.
> Make sense. I'll CC Linus. Comments are welcome.
Can we separate this patch? I'm thinking about CC more people for review. At least, we need to CC all the reviewers of https://lore.kernel.org/all/20230506133134.1492395-1-jacob.jun.pan@xxxxxxxxxxxxxxx/ to this patch. So, it seems more reasonable to separate this patch. What do you think?

Regards,
-Tina