Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile

From: Arnaldo Carvalho de Melo
Date: Fri Oct 27 2023 - 09:36:45 EST


Em Fri, Oct 27, 2023 at 10:43:32AM +0800, Yang Jihong escreveu:
> Sorry, only rename helper and no function change.
> I didn't consider the scenario that might affect test python.

> I've submitted a fix that can be used if needed:

> https://lore.kernel.org/lkml/20231027023028.1106441-1-yangjihong1@xxxxxxxxxx/

> Also, can we consider identifying this problem at the stage of compiling the
> perf tool?

Yes, I have:

$ alias m='rm -rf ~/libexec/perf-core/ ; make -k CORESIGHT=1 O=/tmp/build/$(basename $PWD) -C tools/perf install-bin && perf test python'

And use the 'm' alias to build perf.

I also run 'perf test' before sending patches upstream, in addition to:

make -C tools/perf build-test

I encourage everybody to do the same.

Additionally I run a long list of container tests on dozens of distros,
but those should really be running on some CI system :-\

- Arnaldo