Re: [PATCH v2] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT"

From: André Draszik
Date: Fri Oct 27 2023 - 09:39:10 EST


On Fri, 2023-10-27 at 15:24 +0200, Miklos Szeredi wrote:
> On Fri, Oct 27, 2023 at 3:14 PM André Draszik
> <andre.draszik@xxxxxxxxxx> wrote:
>
> > The patch in question has broken all users that use the higher
> > flags
> > and that don't use your version of libfuse, not just Android.
> > You're
> > filtering them out now when you didn't at the time that those
> > ('official) high flags were added. There are a couple more high
> > flags
> > than just the one that Android added.
>
> Okay.  Where are all those users?

That's not the point. The point is the kernel<->user API has rendered
them too non-working.

>   Why haven't they reported this?

Again, not the point. If I was to ask my crystal ball, Android is
trying to track the upstream kernel closely, others might not and might
not have bumped into this issue yet. Still, not the point.


Cheers,
A.