Re: [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x rd carrier

[Conor Dooley]

On Fri, Oct 27, 2023 at 01:09:58PM +0200, Krzysztof Kozlowski wrote:
> On 26/10/2023 10:47, Elad Nachman wrote:
> > From: Elad Nachman <enachman@xxxxxxxxxxx>
> > 
> > Add dt bindings for AC5X RD COM Express Type 7 carrier board.
> > This board will Accept a CN9131 COM Express Type 7 CPU module.
> > 
> > Signed-off-by: Elad Nachman <enachman@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml     | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > index 52d78521e412..71bc94047d1b 100644
> > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > @@ -60,4 +60,12 @@ properties:
> >            - const: marvell,armada-ap807-quad
> >            - const: marvell,armada-ap807
> >  
> > +      - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP
> > +        items:
> > +          - const: marvell,ac5x_rd_carrier
> 
> No underscores in compatibles.

Oh shit, I didn't notice that somehow. Un-acked until that's removed.

> Do you see them anywhere? Please use
> existing, recent code as start of your contributions, not something
> buggy 5 years old.
> 
> Best regards,
> Krzysztof
>

Attachment: signature.asc
Description: PGP signature