Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate function

[André Apitzsch]

Hi Ricardo,

Am Freitag, dem 27.10.2023 um 14:25 +0200 schrieb Ricardo Ribalda
Delgado:
> Hi Andre
> On Mon, Oct 23, 2023 at 11:49 PM André Apitzsch <git@xxxxxxxxxxx>
> wrote:
> > 
> > Code refinement, no functional changes.
> > 
> > Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>
> 
> With Jacopos comments (don't use de_err_probe())
> Reviewed-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> 
> > +       ret = imx214_ctrls_init(imx214);
> > +       if (ret < 0)
> >                 goto free_ctrl;
> 
> It seems like we can mutex_destroy a non inited mutex. Could you send
> a follow-up patch to fix that?
> 
Sorry, I don't get it. Could you explain what you mean. Thanks.

> Thanks!