Re: [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase

From: Wolfram Sang
Date: Sat Oct 28 2023 - 15:37:51 EST



> > When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
> > the regmap-irq code must be able to perform I2C transactions during
> > suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
> > be suspended/resumed during the NOIRQ phase.
> >
> > Signed-off-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
>
> I think this patch has failed to receive some comments, I'll go
> ahead and give it my blessing:
>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

It needs to be rebased on top of 0ad93449b043 ("i2c: ocores: Remove
#ifdef guards for PM related functions"), though. This series did clean
this up for the whole subsystem. It also introduced using pm_sleep_ptr
which probably was missing here?

Attachment: signature.asc
Description: PGP signature