Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

From: Kirill A. Shutemov
Date: Sun Oct 29 2023 - 10:25:06 EST


On Sat, Oct 28, 2023 at 04:12:10PM +0200, Thomas Gleixner wrote:
> On Fri, Oct 20 2023 at 18:12, Kirill A. Shutemov wrote:
>
> Subject: cpu/hotplug: ...
>
> > ACPI MADT doesn't allow to offline CPU after it got woke up.
>
> ACPI MADT is a table ...
>
> This is about the MADT mailbox wakeup method, right?
>
> > Currently offlining hotplug prevented based on the confidential
>
> is prevented
>
> > computing attribute which is set for Intel TDX. But TDX is not
> > the only possible user of the wake up method.
> >
> > Introduce cpu_hotplug_not_supported() that can be called to indicate
> > that CPU offlining should be disabled.
>
> Otherwise the changes look good!

Thanks!

Thomas, could you take a look if the last patch in the series is sane?

--
Kiryl Shutsemau / Kirill A. Shutemov