Re: [PATCH v4 3/3] arm64: dts: cn913x: add device trees for COM Express boards

[Andrew Lunn]

> +++ b/arch/arm64/boot/dts/marvell/ac5x-rd-carrier.dtsi
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2023 Marvell International Ltd.
> + *
> + * Device tree for the AC5X RD Type 7 Com Express carrier board,
> + * This specific board only maintains a PCIe link with the CPU CPU module
> + * module, which does not require any special DTS definitions.
> + */
> +
> +/ {
> +	model = "Marvell Armada AC5X RD COM EXPRESS type 7 carrier board";
> +	compatible = "marvell,rd-ac5x-carrier", "marvell,cn9131", "marvell,cn9130",
> +		     "marvell,armada-ap807-quad", "marvell,armada-ap807";

This sees wrong to me. Say i mount a congatec Module in it. Its then
is not compatible with marvell,cn9131 etc. I think you should just
list the carrier compatible here.

> +#include "cn9130-db.dtsi"
> +
> +/ {
> +	model = "Marvell Armada CN9130-DB COM EXPRESS type 7 CPU module board";
> +	compatible = "marvell,cn9130-cpu-module", "marvell,cn9130",
> +		     "marvell,armada-ap807-quad", "marvell,armada-ap807";
> +
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x0 0x0 0x2 0x00000000>;

Is the memory soldered down, or socketed?

	Andrew