Re: [PATCH V3][3/4] mmc: Add dw mobile mmc cmdq rtk driver

[Krzysztof Kozlowski]

On 30/10/2023 08:30, Jyan Chou [周芷安] wrote:
> Hi Krzysztof,
> 
>> Use Linux coding style. This driver looks like one for staging, not ready for submission. :/
> 
> We had modified our code to match Linux coding style.

Unfortunately, not much...

> 
>>> +     mcq_writel(host, AHB, 0);
>>> +     dev_info(dev, "AHB=0x%x, dw_mci_cqe_suspend ret=%d\n",
>>> +              mcq_readl(host, AHB), ret);
>> Drop useless success/function entry/exit messages..
> 
> We had drop useless function.
> 
>> Why? This is not an error. If it were, then it should be build stage error.
> 
> It was our mistake to use dev_err here, we had corrected it.

I have no clue what you are referring to. Respond inline as requested by
mailing list etiquette.

> 
>> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong.
> 
> We had removed MODULE_ALIAS().
> Please check our new post below, thanks.
> https://patchwork.kernel.org/project/linux-mmc/patch/20231030062749.2840-4-jyanchou@xxxxxxxxxxx/

Please rework the driver from scratch to look like Linux driver. It was
not looking at the beginning at all.


Best regards,
Krzysztof