Re: [PATCH v2] firmware: ti_sci: Fix an off-by-one in ti_sci_debugfs_create()

From: Dan Carpenter
Date: Mon Oct 30 2023 - 07:06:46 EST


On Mon, Oct 30, 2023 at 11:12:26AM +0100, Christophe JAILLET wrote:
> The ending NULL is not taken into account by strncat(), so switch to
> snprintf() to correctly build 'debug_name'.
>
> Using snprintf() also makes the code more readable.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> v2:
> - use snprintf() to simplify code [Dan Carpenter]
>

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter