Re: [PATCH net] net: page_pool: add missing free_percpu when page_pool_init fail

From: Jiri Pirko
Date: Mon Oct 30 2023 - 08:07:18 EST


Mon, Oct 30, 2023 at 10:12:56AM CET, shaojijie@xxxxxxxxxx wrote:
>From: Jian Shen <shenjian15@xxxxxxxxxx>
>
>When ptr_ring_init() returns failure in page_pool_init(), free_percpu()
>is not called to free pool->recycle_stats, which may cause memory
>leak.

Would be nice to see the use of imperative mood in the patch description
too, not only patch subject. Nevertheless, fix looks fine:

Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>