Re: [PATCH V4][4/4] dt-bindings: mmc: Add dt-bindings for realtek mmc driver
From: Rob Herring
Date: Mon Oct 30 2023 - 09:09:09 EST
On Mon, 30 Oct 2023 14:27:49 +0800, Jyan Chou wrote:
> Document the device-tree bindings for Realtek SoCs mmc driver.
>
> Signed-off-by: Jyan Chou <jyanchou@xxxxxxxxxxx>
>
> ---
> v3 -> v4:
> - Rename compatible(add SoC-specific part) to be different from filename.
> - Describe the items to make properties and item easy to understand.
> - Fix examples' indentation and compiling error.
> - Drop useless properties.
>
> v2 -> v3:
> - Modify dt-bindings' content and description.
> - Fix coding style.
> - Update the list of maintainers.
>
> v0 -> v2:
> - Add dt-bindings.
> ---
> ---
> .../bindings/mmc/realtek-dw-mshc.yaml | 161 ++++++++++++++++++
> 1 file changed, 161 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties:required: ['compatible', 'reg', 'reg-names', 'interrupts', 'clocks', 'clock-names', 'pinctrl-names'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties:examples: ['emmc: mmc@12000 {\n compatible = "realtek,rtd1325-dw-cqe-emmc";\n reg = <0x00012000 0x00600>,\n <0x00012180 0x00060>;\n reg-names = "emmc", "cqhci";\n interrupts = <0 42 4>;\n clocks = <&cc 22>, <&cc 26>, <&cc 121>, <&cc 122>;\n clock-names = "biu", "ciu", "vp0", "vp1";\n clock-freq-min-max = <300000 400000000>;\n clock-frequency = <400000>;\n vmmc-supply = <®_vcc1v8>;\n resets = <&rst 20>;\n reset-names = "reset";\n speed-step = <3>;\n cqe = <1>;\n pinctrl-names = "default", "sdr50", "ddr50", "hs200", "hs400",\n "tune0","tune1", "tune2","tune3", "tune4";\n pinctrl-0 = <&emmc_pins_sdr50>;\n pinctrl-1 = <&emmc_pins_sdr50>;\n pinctrl-2 = <&emmc_pins_ddr50>;\n pinctrl-3 = <&emmc_pins_hs200>;\n pinctrl-4 = <&emmc_pins_hs400>;\n pinctrl-5 = <&emmc_pins_tune0>;\n pinctrl-6 = <&emmc_pins_tune1>;\n pinctrl-7 = <&emmc_pins_tu
ne2>;\n pinctrl-8 = <&emmc_pins_tune3>;\n pinctrl-9 = <&emmc_pins_tune4>;\n };\n'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties: 'required' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
hint: A json-schema keyword was found instead of a DT property name.
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties: 'unevaluatedProperties' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
hint: A json-schema keyword was found instead of a DT property name.
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties:required: ['compatible', 'reg', 'reg-names', 'interrupts', 'clocks', 'clock-names', 'pinctrl-names'] is not of type 'object', 'boolean'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties:reg-names: {'maxItems': 2, 'items': [{'const': 'emmc'}, {'const': 'cqhci'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: properties:examples: ['emmc: mmc@12000 {\n compatible = "realtek,rtd1325-dw-cqe-emmc";\n reg = <0x00012000 0x00600>,\n <0x00012180 0x00060>;\n reg-names = "emmc", "cqhci";\n interrupts = <0 42 4>;\n clocks = <&cc 22>, <&cc 26>, <&cc 121>, <&cc 122>;\n clock-names = "biu", "ciu", "vp0", "vp1";\n clock-freq-min-max = <300000 400000000>;\n clock-frequency = <400000>;\n vmmc-supply = <®_vcc1v8>;\n resets = <&rst 20>;\n reset-names = "reset";\n speed-step = <3>;\n cqe = <1>;\n pinctrl-names = "default", "sdr50", "ddr50", "hs200", "hs400",\n "tune0","tune1", "tune2","tune3", "tune4";\n pinctrl-0 = <&emmc_pins_sdr50>;\n pinctrl-1 = <&emmc_pins_sdr50>;\n pinctrl-2 = <&emmc_pins_ddr50>;\n pinctrl-3 = <&emmc_pins_hs200>;\n pinctrl-4 = <&emmc_pins_hs400>;\n pinctrl-5 = <&emmc_pins_tune0>;\n pinctrl-6 = <&emmc_pins_tune1>;\n pinctrl-7 = <&emmc_pins_tu
ne2>;\n pinctrl-8 = <&emmc_pins_tune3>;\n pinctrl-9 = <&emmc_pins_tune4>;\n };\n'] is not of type 'object', 'boolean'
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: 'oneOf' conditional failed, one must be fixed:
'unevaluatedProperties' is a required property
'additionalProperties' is a required property
hint: Either unevaluatedProperties or additionalProperties must be present
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml: cqe: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231030062749.2840-5-jyanchou@xxxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.