Re: [PATCH v5] dt-bindings: hwmon: lm87: convert to YAML

[Krzysztof Kozlowski]

On 30/10/2023 13:52, Li peiyu wrote:
> Convert the lm87 hwmon sensor bindings to DT schema
> 
> Signed-off-by: Li peiyu <579lpy@xxxxxxxxx>
> ---
> Change for v5:
> - Change the file name to "ti,lm87.yaml"
> - Add maintainers get by get_maintainers.pl

Thank you for your patch. There is something to discuss/improve.

...

> diff --git a/Documentation/devicetree/bindings/hwmon/ti,lm87.yaml b/Documentation/devicetree/bindings/hwmon/ti,lm87.yaml
> new file mode 100644
> index 000000000000..6dadf181c9a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,lm87.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ti,lm87.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LM87 hwmon sensor
> +
> +maintainers:
> +  - Jean Delvare <jdelvare@xxxxxxxx>
> +  - Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> +  - Rob Herring <robh+dt@xxxxxxxxxx>

Please drop last two entries. We do not maintain this file. This should
be someone interested in the device, like driver maintainer or recent
contributor. As last resort, you can put there subsystem maintainer if
he is okay with this.

> +
> +properties:
> +  compatible:
> +    const: ti,lm87
> +
> +  reg:
> +    maxItems: 1
> +
> +  has-temp3:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      When set, pins 18 and 19 are configured to be used as a second
> +      remote temperature sensing channel. Otherwise the pins are
> +      configured as voltage input pins in0 and in5.
> +
> +  has-in6:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      When set, pin 5 is configured to be used as voltage input in6.
> +      Otherwise the pin is set as FAN1 input.
> +
> +  has-in7:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      When set, pin 6 is configured to be used as voltage input in7.
> +      Otherwise the pin is set as FAN2 input.
> +
> +  vcc-supply:
> +    description: |
> +      A Phandle for the regulator supplying power, can be configured to

Drop "A Phandle for the"

> +      measure 5.0V power supply. Default is 3.3V.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +

Rest looks good.

Best regards,
Krzysztof