Re: [PATCH v5 13/14] x86/tsc: Mark Secure TSC as reliable clocksource

From: Dave Hansen
Date: Mon Oct 30 2023 - 13:18:39 EST


On 10/29/23 23:36, Nikunj A Dadhania wrote:
...
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 15f97c0abc9d..b0a8546d3703 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -1241,7 +1241,7 @@ static void __init check_system_tsc_reliable(void)
> tsc_clocksource_reliable = 1;
> }
> #endif
> - if (boot_cpu_has(X86_FEATURE_TSC_RELIABLE))
> + if (boot_cpu_has(X86_FEATURE_TSC_RELIABLE) || cc_platform_has(CC_ATTR_GUEST_SECURE_TSC))
> tsc_clocksource_reliable = 1;

Why can't you just set X86_FEATURE_TSC_RELIABLE?