Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde tma_info_system_dram_bw_use metric

[Namhyung Kim]

On Thu, Oct 26, 2023 at 10:12 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Hi Ian,
>
> On Wed, Oct 25, 2023 at 9:20 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Wed, Oct 25, 2023 at 2:56 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > >
> > > On Thu, Oct 5, 2023 at 3:16 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > > >
> > > > On Wed, Sep 27, 2023 at 6:47 AM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
> > > > >
> > > > >
> > > > >
> > > > > On 2023-09-26 4:59 p.m., Ian Rogers wrote:
> > > > > > Broadwell-de has a consumer core and server uncore. The uncore_arb PMU
> > > > > > isn't present and the broadwellx style cbox PMU should be used
> > > > > > instead. Fix the tma_info_system_dram_bw_use metric to use the server
> > > > > > metric rather than client.
> > > > > >
> > > > > > The associated converter script fix is in:
> > > > > > https://github.com/intel/perfmon/pull/111
> > > > > >
> > > > > > Fixes: 7d124303d620 ("perf vendor events intel: Update broadwell variant events/metrics")
> > > > > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> > > > > > ---
> > > > >
> > > > > Thanks Ian. The whole patch series looks good to me.
> > > > >
> > > > > Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > > >
> > > > Would be good to pick this up in perf-tools-next.
> > > >
> > > > Thanks,
> > > > Ian
> > >
> > > Ping.
> >
> > Thanks Namhyung for picking this up. There were two other patches in
> > the v2 patch set that Kan reviewed:
> > https://lore.kernel.org/all/8a6b9556-c82c-4253-a4c1-74d696ad26df@xxxxxxxxxxxxxxx/
> > that I don't see in perf-tools-next.
>
> Sorry about that.  I'll take care of them too.

Applied to perf-tools-next, thanks!