Re: [PATCH v8 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA

From: Rob Herring
Date: Mon Oct 30 2023 - 15:26:38 EST


On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote:
> Added the configuration for MT8195 RDMA. In comparison to MT8183, it
> no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox.
>
> Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> index c043204cf210..504334a76fb3 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -22,6 +22,7 @@ properties:
> compatible:
> enum:
> - mediatek,mt8183-mdp3-rdma
> + - mediatek,mt8195-mdp3-rdma
> - mediatek,mt8195-vdo1-rdma
>
> reg:
> @@ -58,7 +59,7 @@ properties:
>
> mboxes:
> minItems: 1
> - maxItems: 2
> + maxItems: 5
>
> interrupts:
> maxItems: 1
> @@ -98,6 +99,29 @@ allOf:
> - mboxes
> - mediatek,gce-events
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8195-mdp3-rdma
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: RDMA clock
> +
> + mboxes:
> + items:
> + - description: used for 1st data pipe from RDMA
> + - description: used for 2nd data pipe from RDMA
> + - description: used for 3rd data pipe from RDMA
> + - description: used for 4th data pipe from RDMA
> + - description: used for the data pipe from SPLIT

Following the prior comments, add these entries to the top-level
'mboxes' and then here just put 'minItems: 5'.

Rob