Re: [PATCH 2/3] clk: qcom: ipq6018: add USB GDSCs

[Konrad Dybcio]

On 29.10.2023 12:04, Robert Marko wrote:
> On Wed, 25 Oct 2023 at 12:45, Robert Marko <robimarko@xxxxxxxxx> wrote:
>>
>> IPQ6018 has GDSC-s for each of the USB ports, so lets define them as such
>> and drop the curent code that is de-asserting the USB GDSC-s as part of
>> the GCC probe.
>>
>> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> 
> Unfortunately, after testing on multiple devices I hit the same GDSC
> issue I had a long time ago
> that was the reason I did not send this upstream.
> It seems that USB3 port GDSC (USB0 GDSC in code) works just fine,
> however the USB2 one
> (USB1 GDSC in code) it is stuck off and USB2 port will fail due to this:
>     1.607531] ------------[ cut here ]------------
> [    1.607559] usb1_gdsc status stuck at 'off'
> [    1.607592] WARNING: CPU: 0 PID: 35 at gdsc_toggle_logic+0x16c/0x174
> [    1.615120] Modules linked in:
Can you dump GDSCR (the entire 32-bit register) at boot and when toggling?

Konrad