RE: [PATCH 2/2] drivers: rtc: max31335: initial commit

[Miclaus, Antoniu]

> On 31/10/2023 11:23:49+0000, Miclaus, Antoniu wrote:
> > > > +	if (status != MAX31335_STATUS1_DEFAULT)
> > > > +		dev_err_probe(&client->dev, -EINVAL,
> > > > +			      "Unable to read from device.\n");
> > > > +
> > >
> > > That is misleading. The device returned an unexpected status.
> > > I don't know if this really reflects a problem, but it is not
> > > "Unable to read from device".
> > >
> >
> > Since the device lacks an ID register, I found this as a suitable
> > replacement for checking that the communication with the
> > device actually works before the probe function finishes
> > successfully.
> >
> > I will be more specific in the dev_err_probe message in the
> > upcoming patch version.
> >
> 
> What if this is a transient bus error and the device is actually present
> and working?
>  don't like this kind of check, they are not usually useful.
> 

Got it. Will drop the check in the next patch version.

> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://urldefense.com/v3/__https://bootlin.com__;!!A3Ni8CS0y2Y!9HB62f
> 1sSispWlqUtpamRif0eXxFGCqLzQD3KSwVl9t97YNev9s6akJCbWJ71dcIettiLkqz
> xyFpR_e8H_tCWl82OcBdHjBG$