Re: [PATCH] drm/tilcdc: Fix irq free on unload

[Aradhya Bhatia]

On 19-Sep-23 12:42, Tomi Valkeinen wrote:
> The driver only frees the reserved irq if priv->irq_enabled is set to
> true. However, the driver mistakenly sets priv->irq_enabled to false,
> instead of true, in tilcdc_irq_install(), and thus the driver never
> frees the irq, causing issues on loading the driver a second time.
> 
> Fixes: b6366814fa77 ("drm/tilcdc: Convert to Linux IRQ interfaces")
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Aradhya Bhatia <a-bhatia1@xxxxxx>

Regards
Aradhya

>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index fe56beea3e93..83233bdc0526 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -138,7 +138,7 @@ static int tilcdc_irq_install(struct drm_device *dev, unsigned int irq)
>  	if (ret)
>  		return ret;
>  
> -	priv->irq_enabled = false;
> +	priv->irq_enabled = true;
>  
>  	return 0;
>  }
> 
> ---
> base-commit: 0663e1da5ba8e6459e3555ac12c62741668c0d30
> change-id: 20230919-lcdc-9e09e94f4e93
> 
> Best regards,