Re: [PATCH next] ALSA: hda: cs35l41: Fix missing error code in cs35l41_smart_amp()

[Takashi Iwai]

On Mon, 30 Oct 2023 08:08:36 +0100,
Harshit Mogalapalli wrote:
> 
> When firmware status is invalid, assign -EINVAL to ret as ret is '0' at
> that point and returning success is incorrect when firmware status is
> invalid.
> 
> Fixes: a51d8ba03a4f ("ALSA: hda: cs35l41: Check CSPL state after loading firmware")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>

Thanks, applied now.


Takashi


> ---
> This is found using smatch and only compile tested.
> ---
>  sound/pci/hda/cs35l41_hda.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 496ff6a9d300..09f8d8fa4c71 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -1042,6 +1042,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41)
>  	default:
>  		dev_err(cs35l41->dev, "Firmware status is invalid: %u\n",
>  			fw_status);
> +		ret = -EINVAL;
>  		goto clean_dsp;
>  	}
>  
> -- 
> 2.39.3
>