Re: mainline build failure due to 5cfd69775eb5 ("bcachefs: Array bounds fixes")

[Kent Overstreet]

On Tue, Oct 31, 2023 at 10:15:09PM +0000, Sudip Mukherjee (Codethink) wrote:
> Hi All,
> 
> The latest mainline kernel branch fails to build arm64 allmodconfig
> with a native build on an arm64 host with the error:
> 
> In file included from fs/bcachefs/btree_io.c:11:
> fs/bcachefs/btree_update_interior.h: In function 'want_new_bset':
> fs/bcachefs/btree_update_interior.h:274:36: error: array subscript 0 is outside the bounds of an interior zero-length array 'struct bkey_packed[0]' [-Werror=zero-length-bounds]
>   274 |   __bch_btree_u64s_remaining(c, b, &bne->keys.start[0]);
>       |                                    ^~~~~~~~~~~~~~~~~~~
> In file included from fs/bcachefs/bcachefs.h:206,
>                  from fs/bcachefs/btree_io.c:3:
> fs/bcachefs/bcachefs_format.h:2344:21: note: while referencing 'start'
>  2344 |  struct bkey_packed start[0];
>       |                     ^~~~~
> 
> git bisect pointed to 5cfd69775eb5 ("bcachefs: Array bounds fixes").
> 
> I will be happy to test any patch or provide any extra log if needed.

Following patch should resolve everything:

-- >8 --