Re: [PATCH 2/3] cpufreq: CPPC: Keep the target core awake when reading its cpufreq rate
From: kernel test robot
Date: Tue Oct 31 2023 - 19:53:13 EST
Hi Zeng,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/acpi-bus arm64/for-next/core linus/master v6.6 next-20231031]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zeng-Heng/arm64-cpufeature-Export-cpu_has_amu_feat/20231025-173559
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20231025093847.3740104-3-zengheng4%40huawei.com
patch subject: [PATCH 2/3] cpufreq: CPPC: Keep the target core awake when reading its cpufreq rate
config: arm64-randconfig-003-20231101 (https://download.01.org/0day-ci/archive/20231101/202311010726.MjF49sPn-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311010726.MjF49sPn-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311010726.MjF49sPn-lkp@xxxxxxxxx/
All error/warnings (new ones prefixed by >>):
drivers/cpufreq/cppc_cpufreq.c: In function 'cppc_get_perf_ctrs_pair':
>> drivers/cpufreq/cppc_cpufreq.c:852:26: error: invalid use of undefined type 'struct fb_ctr_pair'
852 | int cpu = fb_ctrs->cpu;
| ^~
drivers/cpufreq/cppc_cpufreq.c:855:47: error: invalid use of undefined type 'struct fb_ctr_pair'
855 | ret = cppc_get_perf_ctrs(cpu, &fb_ctrs->fb_ctrs_t0);
| ^~
drivers/cpufreq/cppc_cpufreq.c:861:48: error: invalid use of undefined type 'struct fb_ctr_pair'
861 | return cppc_get_perf_ctrs(cpu, &fb_ctrs->fb_ctrs_t1);
| ^~
drivers/cpufreq/cppc_cpufreq.c: In function 'cppc_cpufreq_get_rate':
>> drivers/cpufreq/cppc_cpufreq.c:866:16: error: variable 'fb_ctrs' has initializer but incomplete type
866 | struct fb_ctr_pair fb_ctrs = { .cpu = cpu, };
| ^~~~~~~~~~~
>> drivers/cpufreq/cppc_cpufreq.c:866:41: error: 'struct fb_ctr_pair' has no member named 'cpu'
866 | struct fb_ctr_pair fb_ctrs = { .cpu = cpu, };
| ^~~
>> drivers/cpufreq/cppc_cpufreq.c:866:47: warning: excess elements in struct initializer
866 | struct fb_ctr_pair fb_ctrs = { .cpu = cpu, };
| ^~~
drivers/cpufreq/cppc_cpufreq.c:866:47: note: (near initialization for 'fb_ctrs')
>> drivers/cpufreq/cppc_cpufreq.c:866:28: error: storage size of 'fb_ctrs' isn't known
866 | struct fb_ctr_pair fb_ctrs = { .cpu = cpu, };
| ^~~~~~~
>> drivers/cpufreq/cppc_cpufreq.c:866:28: warning: unused variable 'fb_ctrs' [-Wunused-variable]
vim +852 drivers/cpufreq/cppc_cpufreq.c
848
849 static int cppc_get_perf_ctrs_pair(void *val)
850 {
851 struct fb_ctr_pair *fb_ctrs = val;
> 852 int cpu = fb_ctrs->cpu;
853 int ret;
854
855 ret = cppc_get_perf_ctrs(cpu, &fb_ctrs->fb_ctrs_t0);
856 if (ret)
857 return ret;
858
859 udelay(2); /* 2usec delay between sampling */
860
861 return cppc_get_perf_ctrs(cpu, &fb_ctrs->fb_ctrs_t1);
862 }
863
864 static unsigned int cppc_cpufreq_get_rate(unsigned int cpu)
865 {
> 866 struct fb_ctr_pair fb_ctrs = { .cpu = cpu, };
867 struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
868 struct cppc_cpudata *cpu_data = policy->driver_data;
869 u64 delivered_perf;
870 int ret;
871
872 cpufreq_cpu_put(policy);
873
874 if (cpu_has_amu_feat(cpu))
875 ret = smp_call_on_cpu(cpu, cppc_get_perf_ctrs_pair,
876 &fb_ctrs, false);
877 else
878 ret = cppc_get_perf_ctrs_pair(&fb_ctrs);
879
880 if (ret)
881 return 0;
882
883 delivered_perf = cppc_perf_from_fbctrs(cpu_data,
884 &fb_ctrs.fb_ctrs_t0,
885 &fb_ctrs.fb_ctrs_t1);
886
887 return cppc_cpufreq_perf_to_khz(cpu_data, delivered_perf);
888 }
889
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki