Re: [PATCH v1] hwmon: emc1403: Add support for EMC1442

[Patrick Williams]

On Tue, Oct 31, 2023 at 04:01:10PM -0700, Guenter Roeck wrote:
> On Tue, Oct 31, 2023 at 04:58:06PM +0800, Delphine CC Chiu wrote:
> > Add support for EMC1442 which is compatible with EMC1403.
> > 
> 
> Unfortunately, almost no information is available about this chip
> except that it ships in an 8-pin package. Are you sure the chip
> supports two external temperature sensors like EMC1403 ?
> The chip numbering and the number of pins would suggest that
> it only supports a single external temperature sensor,
> which would make it compatible to emc1402/emc1422.
> 
> Guenter

The datasheet I've seen says:

>> The EMC1442 monitors two temperature channels (one
>> external and one internal).

Based on this, I agree that emc1403 seems wrong.  The datasheet also
says:

>> Pin compatible with EMC1412

> 
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> > ---
> >  	{ "emc1422", emc1402 },
> >  	{ "emc1423", emc1403 },
> >  	{ "emc1424", emc1404 },
> > +	{ "emc1442", emc1403 },

So, emc1402?

> >  	{ }

-- 
Patrick Williams

Attachment: signature.asc
Description: PGP signature