Re: [PATCH v2] scsi: ufs: ufs-sysfs: Expose UFS power info

[Can Guo]

Hi Bart,

On 11/1/2023 12:23 AM, Bart Van Assche wrote:
> On 10/31/23 02:53, Can Guo wrote:
> > +What: /sys/bus/platform/drivers/ufshcd/*/power_info/mode
> > +What:        /sys/bus/platform/devices/*.ufs/power_info/mode
> > +Date:        September 2023
> > +Contact:    Can Guo <quic_cang@xxxxxxxxxxx>
> > +Description:    This file shows the UniPro power mode of UFS link:
> > +        == ====================================================
> > +        1   FAST_MODE
> > +        2   SLOW_MODE
> > +        4   FASTAUTO_MODE
> > +        5   SLOWAUTO_MODE
> > +        == ====================================================
> > +
> > +        The file is read only.
>
> For this attribute and the attributes below, shouldn't these be exported
> as text instead of as numbers? Shell scripts that read and use these
> attributes will be much easier to read if these attributes are changed
> from numeric into a textual.

Done.


Thanks,

Can Guo.

> Thanks,
>
> Bart.