Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board

[Mukesh Ojha]

On 11/6/2023 6:35 PM, Krzysztof Kozlowski wrote:
> On 06/11/2023 12:41, Mukesh Ojha wrote:
>
> > > I agree here. What exactly is common in the real hardware between IDP
> > > and RB3? Commit msg does not explain it, so I do not see enough
> > > justification for common file. Just because some DTS looks similar for
> > > different hardware does not mean you should creat common file.
> >
> > @Dmitry/@Krzysztof,
> >
> > Thank you for reviewing the RFC, we wanted to continue the
> > suggestion/discussion given on [1] , where we discussed that this
> > qcm6490 is going to be targeted for IOT segment and will have different
> > memory map and it is going to use some of co-processors like adsp/cdsp
> > which chrome does not use.
> >
> > So to your question what is common between RB3 and IDP, mostly they will
> > share common memory map(similar to [2]) and regulator settings and both
>
> The question was what is common hardware, not common in your DTS.

Got your point.
Let me know if you agree with the suggestion shared here

https://lore.kernel.org/lkml/CAA8EJpq89g9EeyKcogU+Mt9ie6Bk-rmgi=GqyycYBm_291i1Bw@xxxxxxxxxxxxxx/

-Mukesh
> > will use adsp/cdsp etc., we will be posting the memory map changes as
> > well in coming weeks once this RFC is acked.
>
> Sorry, that's not common part of hardware.
>
> Best regards,
> Krzysztof