Re: [PATCH 2/3] dt-bindings: trivial-devices: add asair,ags02ma

[Krzysztof Kozlowski]

On 07/11/2023 18:30, Anshul Dalal wrote:
> Add bindings for Asair AGS02MA TVOC sensor to trivial devices.
> 
> The sensor communicates over i2c with the default address 0x1a.
> TVOC values can be read in the units of ppb and ug/m^3 at register 0x00.
> 
> Datasheet:
>   https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf
> Product-Page:
>   http://www.aosong.com/m/en/products-33.html
> 
> Signed-off-by: Anshul Dalal <anshulusr@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index cd58179ae337..9cd67b758a88 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -47,6 +47,8 @@ properties:
>            - adi,lt7182s
>              # AMS iAQ-Core VOC Sensor
>            - ams,iaq-core
> +            # TVOC (Total Volatile Organic Compounds) i2c sensor
> +          - asair,ags02ma

I think you miss VDD supply.

Best regards,
Krzysztof