Re: [PATCH 08/10] kprobes: Remove the now superfluous sentinel elements from ctl_table array

[Google]

On Tue, 07 Nov 2023 14:45:08 +0100
Joel Granados via B4 Relay <devnull+j.granados.samsung.com@xxxxxxxxxx> wrote:

> From: Joel Granados <j.granados@xxxxxxxxxxx>
> 
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/)
> 
> Remove sentinel element from kprobe_sysclts

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks,

> 
> Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx>
> ---
>  kernel/kprobes.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 0c6185aefaef..d049b602dd41 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -968,7 +968,6 @@ static struct ctl_table kprobe_sysctls[] = {
>  		.extra1		= SYSCTL_ZERO,
>  		.extra2		= SYSCTL_ONE,
>  	},
> -	{}
>  };
>  
>  static void __init kprobe_sysctls_init(void)
> 
> -- 
> 2.30.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>