Re: [PATCH v5 3/3] Input: cap11xx - remove unnecessary IRQ parsing

From: Rob Herring
Date: Wed Nov 08 2023 - 14:53:56 EST


On Wed, Nov 8, 2023 at 9:57 AM Jiri Valek - 2N <jiriv@xxxxxxxx> wrote:
>
> Separate IRQ parsing is not necessary, I2C core do the job.
>
> Signed-off-by: Jiri Valek - 2N <jiriv@xxxxxxxx>
> ---
> drivers/input/keyboard/cap11xx.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> index 4711ea985627..ccca9936ef25 100644
> --- a/drivers/input/keyboard/cap11xx.c
> +++ b/drivers/input/keyboard/cap11xx.c
> @@ -518,7 +518,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> struct device *dev = &i2c_client->dev;
> struct cap11xx_priv *priv;
> const struct cap11xx_hw_model *cap;
> - int i, error, irq;
> + int i, error;
> unsigned int val, rev;
>
> if (id->driver_data >= ARRAY_SIZE(cap11xx_devices)) {
> @@ -624,13 +624,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> if (error)
> return error;
>
> - irq = irq_of_parse_and_map(dev->of_node, 0);

Probably can drop the include of of_irq.h as well.